fix ots

.gitea/workflows/android-release.yml

@@ -74,6 +74,30 @@ jobs:
           printf '%s' "$KEYSTORE_BASE64" | base64 -d > "$RUNNER_TEMP/kadence.keystore"
           echo "signed=true" >> "$GITHUB_OUTPUT"
 
+      # A keystore without its password and alias cannot sign anything. Gradle
+      # would eventually fail in `packageRelease`, after the build and R8 have
+      # run; checking here says which secret is missing in a few seconds.
+      - name: Check the signing secrets
+        if: steps.key.outputs.signed == 'true'
+        env:
+          STORE_PASSWORD: ${{ secrets.KADENCE_KEYSTORE_PASSWORD }}
+          KEY_ALIAS: ${{ secrets.KADENCE_KEY_ALIAS }}
+          KEY_PASSWORD: ${{ secrets.KADENCE_KEY_PASSWORD }}
+        run: |
+          missing=()
+          [ -n "${STORE_PASSWORD:-}" ] || missing+=(KADENCE_KEYSTORE_PASSWORD)
+          [ -n "${KEY_ALIAS:-}" ] || missing+=(KADENCE_KEY_ALIAS)
+          [ -n "${KEY_PASSWORD:-}" ] || missing+=(KADENCE_KEY_PASSWORD)
+          if [ ${#missing[@]} -gt 0 ]; then
+            echo "::error::Missing signing secret(s): ${missing[*]}"
+            exit 1
+          fi
+          if ! keytool -list -keystore "$RUNNER_TEMP/kadence.keystore" \
+              -storepass "$STORE_PASSWORD" -alias "$KEY_ALIAS" >/dev/null 2>&1; then
+            echo "::error::KADENCE_KEYSTORE_PASSWORD or KADENCE_KEY_ALIAS does not open the keystore."
+            exit 1
+          fi
+
       - name: Resolve the version name
         run: |
           if [[ "$GITHUB_REF" == refs/tags/v* ]]; then
@@ -137,13 +161,13 @@ jobs:
             "$SIGNER_SHA256" > "$META_DIR/update.json"
           cat "$META_DIR/update.json"
 
-      - uses: actions/upload-artifact@v3
+      - uses: https://gitea.com/actions/gitea-upload-artifact@v4
         with:
           name: kadence-release-apk
           path: android/app/build/outputs/apk/release/app-release.apk
           if-no-files-found: error
 
-      - uses: actions/upload-artifact@v3
+      - uses: https://gitea.com/actions/gitea-upload-artifact@v4
         with:
           name: kadence-update-metadata
           path: android/app/build/outputs/update/update.json